T_IDENTIFIER ➔ ??? - Code Metrics - Inspection of "Various fixes" - cosmocode/dokuwiki-plugin-prosemirror - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#39)

by Michael

created 2018-06-08 16:14 UTC

T_IDENTIFIER ➔ ??? A

↳ Parent: Project

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
nc	4
nop	0
dl	0
loc	1
rs	10

jQuery(function initializeProsemirror() {

    const $toggleEditorButton = jQuery('.plugin_prosemirror_useWYSIWYG');
    $toggleEditorButton.on('click', function() {
        const $current = DokuCookie.getValue('plugin_prosemirror_useWYSIWYG');

        DokuCookie.setValue('plugin_prosemirror_useWYSIWYG', $current ? '' : '1');
    });

    const $jsonField = jQuery('#dw__editform').find('[name=prosemirror_json]');
    if (!$jsonField.length) {
        return;
    }
    $jsonField.attr('id', 'prosemirror_json');

    try {

        /* DOKUWIKI:include lib/bundle.js */
    } catch (e) {

        const $textArea = jQuery('#wiki__text');

        let message = 'There was an error in the WYSIWYG editor. You will be redirected to the syntax editor in 5 seconds.';

        if (window.SentryPlugin) {
            SentryPlugin.logSentryException(e, {
                tags: {
                    plugin: 'prosemirror',
                    'id': JSINFO.id,
                },
                extra: {
                    'content': $textArea.val(),
                }
            });
            message += ' The error has been logged to sentry.';
        }
        $textArea.replaceWith('<div class="error">'+ message + '</div>');
        setTimeout(function() {
            $toggleEditorButton.click();

        }, 5000);
        return;
    }

    jQuery('#wiki__text').hide();
    jQuery('#size__ctl').hide();
    jQuery('.editBox > .toolbar').hide();
});


1			jQuery(function initializeProsemirror() {
2
3			const $toggleEditorButton = jQuery('.plugin_prosemirror_useWYSIWYG');
4			$toggleEditorButton.on('click', function() {
5			const $current = DokuCookie.getValue('plugin_prosemirror_useWYSIWYG');
			0 ignored issues – show Bug introduced 2018-06-04 16:10 UTC by Report Bug Copy Issue Report The variable `DokuCookie` seems to be never declared. If this is a global, consider adding a `/** global: DokuCookie */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
6			DokuCookie.setValue('plugin_prosemirror_useWYSIWYG', $current ? '' : '1');
7			});
8
9			const $jsonField = jQuery('#dw__editform').find('[name=prosemirror_json]');
10			if (!$jsonField.length) {
11			return;
12			}
13			$jsonField.attr('id', 'prosemirror_json');
14
15			try {
			0 ignored issues – show Unused Code introduced 2018-06-04 16:10 UTC by Report Bug Copy Issue Report Empty try statement found. This statement can be removed. Loading history... Comprehensibility Documentation Best Practice introduced 2018-06-04 16:10 UTC by Report Bug Copy Issue Report This code block is empty. Consider removing it or adding a comment to explain. Loading history...
16			/* DOKUWIKI:include lib/bundle.js */
17			} catch (e) {
			0 ignored issues – show introduced 2018-06-04 16:10 UTC by Report Bug Copy Issue Report This code is unreachable and can thus be removed without consequences. Loading history...
18			const $textArea = jQuery('#wiki__text');
			0 ignored issues – show Bug introduced 2018-06-04 16:10 UTC by Report Bug Copy Issue Report The variable `$textArea` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.$textArea`. Loading history...
19			let message = 'There was an error in the WYSIWYG editor. You will be redirected to the syntax editor in 5 seconds.';
			0 ignored issues – show Bug introduced 2018-06-04 16:10 UTC by Report Bug Copy Issue Report The variable `message` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.message`. Loading history...
20			if (window.SentryPlugin) {
21			SentryPlugin.logSentryException(e, {
22			tags: {
23			plugin: 'prosemirror',
24			'id': JSINFO.id,
25			},
26			extra: {
27			'content': $textArea.val(),
28			}
29			});
30			message += ' The error has been logged to sentry.';
31			}
32			$textArea.replaceWith('<div class="error">'+ message + '</div>');
33			setTimeout(function() {
34			$toggleEditorButton.click();
			0 ignored issues – show Bug introduced 2018-06-04 16:10 UTC by Report Bug Copy Issue Report The variable `$toggleEditorButton` seems to be never declared. If this is a global, consider adding a `/** global: $toggleEditorButton */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
35			}, 5000);
36			return;
37			}
38
39			jQuery('#wiki__text').hide();
40			jQuery('#size__ctl').hide();
41			jQuery('.editBox > .toolbar').hide();
42			});
43

cosmocode / dokuwiki-plugin-prosemirror

Pull Request — master (#39)

T_IDENTIFIER ➔ ??? A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like